Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage to ensure the public API remains usable #23

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 6, 2024

Since moving to propcache.api, we didn't have any coverage that it was usable externally.

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 6, 2024
@bdraco bdraco enabled auto-merge (squash) October 6, 2024 16:18
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base (fd4f135) to head (9cbf0dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   86.49%   86.63%   +0.13%     
==========================================
  Files          14       15       +1     
  Lines         585      591       +6     
  Branches       50       50              
==========================================
+ Hits          506      512       +6     
  Misses         63       63              
  Partials       16       16              
Flag Coverage Δ
CI-GHA 86.29% <100.00%> (+0.14%) ⬆️
MyPy 68.92% <50.00%> (-0.21%) ⬇️
OS-Linux 99.13% <100.00%> (+0.90%) ⬆️
OS-Windows 96.42% <100.00%> (+1.16%) ⬆️
OS-macOS 96.98% <100.00%> (+0.96%) ⬆️
Py-3.10.11 96.98% <100.00%> (+0.96%) ⬆️
Py-3.10.15 98.70% <100.00%> (+0.91%) ⬆️
Py-3.11.10 98.70% <100.00%> (+0.91%) ⬆️
Py-3.11.9 96.98% <100.00%> (+0.96%) ⬆️
Py-3.12.6 98.70% <100.00%> (+0.91%) ⬆️
Py-3.13.0-rc.3 98.70% <100.00%> (+0.91%) ⬆️
Py-3.8.10 78.87% <100.00%> (+1.44%) ⬆️
Py-3.8.18 80.60% <100.00%> (+1.39%) ⬆️
Py-3.9.13 96.98% <100.00%> (+0.96%) ⬆️
Py-3.9.20 98.70% <100.00%> (+0.91%) ⬆️
Py-pypy7.3.11 94.38% <100.00%> (+1.22%) ⬆️
Py-pypy7.3.16 94.38% <100.00%> (+1.22%) ⬆️
Py-pypy7.3.17 94.38% <100.00%> (+1.22%) ⬆️
VM-macos-latest 96.98% <100.00%> (+0.96%) ⬆️
VM-ubuntu-latest 99.13% <100.00%> (+0.90%) ⬆️
VM-windows-latest 96.42% <100.00%> (+1.16%) ⬆️
pytest 99.13% <100.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco disabled auto-merge October 6, 2024 16:29
@bdraco bdraco merged commit f35d343 into master Oct 6, 2024
47 of 49 checks passed
@bdraco bdraco deleted the cov_api branch October 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant